-
Notifications
You must be signed in to change notification settings - Fork 2.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update dependency containers/automation_images to v20230807 #19541
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
DO NOT MERGE: There's a FIXME
that requires fixing.
1a35a87
to
e4c1ea5
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Still DO NOT MERGE: I want to see if the "lookup cdn03.quay.io" flake still reproduces.
If you test this in podman, it's imperative to do with without FWIW Miro Vadkerti was seeing the |
Oh okay thanks. I'll just grep the ginkgo log files then (assuming we still collect them).
Noted. |
Ugg, speak of the devil. This flake reproduced on the 4.4.1-rhel branch cirrus-cron run the other night. So it's definitely still alive and kicking 😢 |
e4c1ea5
to
407cfe5
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM assuming tests pass.
Edited/Blocked NotificationRenovate will not automatically rebase this PR, because it does not recognize the last commit author and assumes somebody else may have edited the PR. You can manually request rebase by checking the rebase/retry box above. ⚠ Warning: custom changes will be lost. |
@edsantiago any chance you've seen this debian Error: OCI runtime error: runc: exec failed: unable to start container process: exec: "/etc": is a directory? I didn't see it on the flake list. It's dying on the entire debian matrix 😢 |
Signed-off-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> Signed-off-by: Chris Evich <[email protected]>
My first guess is that |
407cfe5
to
6adf2e9
Compare
Force-push: Rebased. Small fix for Ed. Add one test skip, removed another. |
6adf2e9
to
b261cd8
Compare
Ref: https://github.com/containers/automation_images/pull/288/commits Signed-off-by: Chris Evich <[email protected]>
Signed-off-by: Chris Evich <[email protected]>
An unhelpful comment doesn't give any clues why this test was originally skipped on Ubuntu. In any case, now that CI uses Debian SID, re-enable the test hoping that it now functions. Signed-off-by: Chris Evich <[email protected]>
Ref: #19552 Signed-off-by: Chris Evich <[email protected]>
garrr...I fat-fingered my fix to Ed's date 😱 |
b261cd8
to
7ef0351
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This should be ready for final review assuming tests pass.
Thanks to the kind-soul whom is re-running CI jobs 👍 |
/approved |
/lgtm |
[APPROVALNOTIFIER] This PR is APPROVED Approval requirements bypassed by manually added approval. This pull-request has been approved by: cevich, renovate[bot] The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
This PR contains the following updates:
20230726t191046z-f38f37d13
->20230807t144831z-f38f37d13
Release Notes
containers/automation_images (containers/automation_images)
v20230807t144831z-f38f37d13
Compare Source
Configuration
📅 Schedule: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined).
🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.
♻ Rebasing: Never, or you tick the rebase/retry checkbox.
🔕 Ignore: Close this PR and you won't be reminded about this update again.
This PR has been generated by Mend Renovate. View repository job log here.